Add mode, inline cert iss & trust config to workload identity pool#22787
Merged
modular-magician merged 1 commit intohashicorp:mainfrom May 14, 2025
Conversation
…ashicorp#13814) [upstream:1ffca3b72196be5cee231a0930532f2fa4a30ab5] Signed-off-by: Modular Magician <magic-modules@google.com>
shuyama1
reviewed
May 16, 2025
Comment on lines
+522
to
+523
| // Generated IAM resources: 300 | ||
| // Total generated resources: 896 |
Collaborator
There was a problem hiding this comment.
@c2thorn I think the IAM resources are only added to beta. Can you verify if the number change is intended?
Collaborator
There was a problem hiding this comment.
yes they were set to min_version: beta. we may have an error with this logic. I'll take a look.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#13814