Support helm's new TakeOwnership sdk value #1631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vravind1 can someone of your team take a look at this? It would be great to have this feature! |
|
Hey, this small change can ease lots of things. Will this be reviewed soon please ? |
|
It looks like they merged it from somewhere else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
TakeOwnershipoption in Helm allows Helm to adopt resources that are currently owned by other helm charts or not owned at all. It's only available through the SDK right now. This PR adds atake_ownershipoption tohelm_releasethat makes use of this SDK feature. #1597 is the older draft PR by @lizduty for this feature which got stuck in draft for some reason.Acceptance tests
Release Note
Release note for CHANGELOG:
References
#1597, helm/helm#12876
Community Note