fix inconsistent result after apply

[guillaumebernard84]

Rollback Plan

Simply revert the commit, it's only 3 lines of code.

Changes to Security Controls

None

Description

When upgrading a Helm chart to a new version, the provider threw errors like:

Error: Provider produced inconsistent result after apply
.metadata.version: was cty.StringVal("0.1.0"), but now cty.StringVal("0.1.1")
.metadata.revision: was cty.NumberIntVal(1), but now cty.NumberIntVal(2)
.metadata.last_deployed: was cty.NumberIntVal(1.759344053e+09), but now cty.NumberIntVal(1.759344075e+09).
.metadata.app_version: was cty.StringVal("1.1"), but now cty.StringVal("1.2").

Added a version check to the recomputeMetadata() function:

if !plan.Version.Equal(state.Version) {
    return true
}

Acceptance tests

None, I just tested locally and confirmed I reproduced the bug with the official v3.0.2, and then tested again with the fix to confirm it works.

Release Note

Release note for CHANGELOG:

Fix `Provider produced inconsistent result after apply` error when upgrading an helm chart with v3.0.2

References

Fixes issues #1692 and #1664

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[hashicorp-cla-app]

All committers have signed the CLA.

[sebastienmusso]

Hi merge request seems to be simple and complete, when did you plan te merge it ?

[mkilchhofer]

I think just adding the check will not solve the issue - at least not for my case of a local helm chart (sitting in a directory next to the *.tf files).

I created another PR to address that (moved a function to the end of the diff [ ModifyPlan() ] function):

• fix: Address "inconsistent result after apply" error by moving metadata recalc #1713

[guillaumebernard84]

Hello @mkilchhofer, you are right, I didn't test with local helm charts. No problem to close this PR and merge yours. Thank you