This repository was archived by the owner on Dec 17, 2020. It is now read-only.
Issues #25 - Utilize Network Allocate Function#26
Open
donwlewis wants to merge 1 commit intohashicorp:masterfrom
donwlewis:master
Open
Issues #25 - Utilize Network Allocate Function#26donwlewis wants to merge 1 commit intohashicorp:masterfrom donwlewis:master
donwlewis wants to merge 1 commit intohashicorp:masterfrom
donwlewis:master
Conversation
Contributor
|
Was this tested in your environment? |
Author
|
Yes I tested in my environment, and Create/Delete work fine, but I did not test the read. Not sure read entirely makes sense for this function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
I started this as a separate resource called
infoblox_network_allocationfollowing the naming convention of theinfoblox_ip_allocation. The file is essentially a copy of theinfoblox_networkresource, so I there could be some improvements and consolidation that could happen. I am just not sure exactly how as I am new to provider development.Since the new provider is affectively using the same functions and the network create provider for Delete, Update, and Read functions, it would probably make more sense to use the function in the
infoblox_networkprovider instead of rewriting them in this provider since they would essentially be the same.I have some done some testing with this, and it seems to work fine. If you would like for me to write a go test for it as well, I can work on that too.
Any feedback you might have will be appreciated!