Skip to content

don't error if the key doesn't exist and value is null. #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

don't error if the key doesn't exist and value is null. #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567ff60
don't error if the key doesn't exist and value is null.
kro-cat Aug 14, 2025
e18bcb5
add unit functionality tests for null value handling and morphing
kro-cat Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions manifest/morph/morph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,12 +597,14 @@ func morphObjectToType(v tftypes.Value, t tftypes.Type, p *tftypes.AttributePath
elp := p.WithAttributeName(k)
nt, ok := t.(tftypes.Object).AttributeTypes[k]
if !ok {
diags = append(diags, &tfprotov5.Diagnostic{
Attribute: p,
Severity: tfprotov5.DiagnosticSeverityWarning,
Summary: "Attribute not found in schema",
Detail: fmt.Sprintf("Unable to find schema type for attribute:\n%s", attributePathSummary(elp)),
})
if !v.IsNull() {
diags = append(diags, &tfprotov5.Diagnostic{
Attribute: p,
Severity: tfprotov5.DiagnosticSeverityWarning,
Summary: "Attribute not found in schema",
Detail: fmt.Sprintf("Unable to find schema type for attribute:\n%s", attributePathSummary(elp)),
})
}
continue
}
nv, d := ValueToType(v, nt, elp)
Expand Down
99 changes: 99 additions & 0 deletions manifest/morph/morph_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,105 @@ func TestMorphValueToType(t *testing.T) {
}),
}),
},
// morphing with null-valued attributes
"object -> object (null)": {
In: sampleInType{
V: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"two": tftypes.String,
"three": tftypes.String,
}}, map[string]tftypes.Value{
"two": tftypes.NewValue(tftypes.String, "stuff"),
"three": tftypes.NewValue(tftypes.String, nil),
}),
T: tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
}},
},
Out: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
}}, map[string]tftypes.Value{
"one": tftypes.NewValue(tftypes.Number, nil),
"two": tftypes.NewValue(tftypes.String, "stuff"),
}),
},
"object -> object (deep null)": {
In: sampleInType{
V: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
"bar": tftypes.String,
}},
}}, map[string]tftypes.Value{
"two": tftypes.NewValue(tftypes.String, "stuff"),
"three": tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
"bar": tftypes.String,
}}, map[string]tftypes.Value{
"foo": tftypes.NewValue(tftypes.String, "fourtytwo"),
"bar": tftypes.NewValue(tftypes.String, nil),
}),
}),
T: tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{"foo": tftypes.String}},
}},
},
Out: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{"foo": tftypes.String}},
}}, map[string]tftypes.Value{
"one": tftypes.NewValue(tftypes.Number, nil),
"two": tftypes.NewValue(tftypes.String, "stuff"),
"three": tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
}}, map[string]tftypes.Value{
"foo": tftypes.NewValue(tftypes.String, "fourtytwo"),
}),
}),
},
"object -> object (aggregate null)": {
In: sampleInType{
V: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
"bar": tftypes.String,
}},
}}, map[string]tftypes.Value{
"two": tftypes.NewValue(tftypes.String, "stuff"),
"three": tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
"bar": tftypes.String,
}}, map[string]tftypes.Value{
"foo": tftypes.NewValue(tftypes.String, nil),
"bar": tftypes.NewValue(tftypes.String, nil),
}),
}),
T: tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{"foo": tftypes.String}},
}},
},
Out: tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"one": tftypes.Number,
"two": tftypes.String,
"three": tftypes.Object{AttributeTypes: map[string]tftypes.Type{"foo": tftypes.String}},
}}, map[string]tftypes.Value{
"one": tftypes.NewValue(tftypes.Number, nil),
"two": tftypes.NewValue(tftypes.String, "stuff"),
"three": tftypes.NewValue(tftypes.Object{AttributeTypes: map[string]tftypes.Type{
"foo": tftypes.String,
}}, map[string]tftypes.Value{
"foo": tftypes.NewValue(tftypes.String, nil),
}),
}),
},
}
for n, s := range samples {
t.Run(n, func(t *testing.T) {
Expand Down