Skip to content

Conversation

@Tenzer
Copy link

@Tenzer Tenzer commented Oct 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No

Description

This adds support for the sleep action as a pre-stop lifecycle hook. It was graduated to be stable functionality with Kubernetes 1.34:
https://kubernetes.io/blog/2025/08/27/kubernetes-v1-34-release/#sleep-action-for-container-lifecycle-hooks
kubernetes/enhancements#3960

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

Add support for the "sleep" action as a pre-stop lifecycle hook

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@Tenzer Tenzer requested a review from a team as a code owner October 6, 2025 14:01
@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the size/S label Oct 6, 2025
@Tenzer
Copy link
Author

Tenzer commented Oct 6, 2025

I haven't run tests yet, as I'd like to get confirmation that this is approximately the right set of changes to make for this. Also, it looks like there's only tests for the exec pre-stop lifecycle hook at the moment. Perhaps it's worthwhile adding tests for all four variants?

Also, how are docs updated? Are they handled manually or generated from some source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant