Add resources for uuid v4 and v7 #706
Open
+1,535
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainkwan
force-pushed
the
support-uuid-versions
branch
from
3839326 to
8411ece
Compare
|
|
|
Hi @masongup-mdsol, I can review this after signing the CLA. 👍🏽 |
|
Ah okay, I thought I had signed it already, but I guess I didn't finish the workflow properly before. I think it should be good now. |
1 task
|
@rainkwan can you take a look at this when you get some time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #402
Fixes #511
Description
The UUIDs generated by the existing
random_uuidresource are not valid UUIDs per RFC 4122, so they cause problems when a user attempts to use them in a system which expects UUIDs to be a specific version. Per the discussion on #402, I have done this by cloning the existing uuid resource, renaming it as uuid4 and uuid7 respectively, and using the Google Go UUID library instead with the appropriate methods to generate valid UUIDs of the appropriate versions. This way, users of the existinguuidresource will continue to have the same behavior without making any changes. Users who need one of these UUID versions can use the specific resource for that so that it is clear to any readers of the code what version is being used and that that version is being used intentionally.Rollback Plan
Changes to Security Controls
Given that this is random data, there are no security controls involved.