Skip to content

Fix JSON format ignored in some logging subsystems #37435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −3
Open

Fix JSON format ignored in some logging subsystems #37435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f603030
Fix JSON format ignored in some logging subsystems
uristernik Aug 13, 2025
96644bb
Add changelog entry
uristernik Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/v1.14/BUG FIXES-20250814-120000.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: BUG FIXES
body: 'logging: Fixed JSON format being ignored in some logging subsystems when TF_LOG_* environment variables are set to "JSON"'
time: 2025-08-14T12:00:00.000000+00:00
custom:
Issue: "37433"
20 changes: 17 additions & 3 deletions internal/logging/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,26 @@ func globalLogLevel() (hclog.Level, bool) {
if envLevel == "" {
envLevel = strings.ToUpper(os.Getenv(envLogCore))
}
if envLevel == "JSON" {
json = true
}

// Check if JSON formatting is requested by any subsystem
json = isJSONFormatRequested()

return parseLogLevel(envLevel), json
}

// isJSONFormatRequested checks if any logging subsystem has requested JSON formatting
func isJSONFormatRequested() bool {
logEnvVars := []string{envLog, envLogCore, envLogProvider, envLogCloud, envLogStacks}

for _, envVar := range logEnvVars {
if strings.ToUpper(os.Getenv(envVar)) == "JSON" {
return true
}
}

return false
}

func parseLogLevel(envLevel string) hclog.Level {
if envLevel == "" {
return hclog.Off
Expand Down