backend/oss: Bump github.com/aliyun/aliyun-oss-go-sdk to v2.1.1 #37442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog WarningCurrently this PR would target a v1.14 release. Please add a changelog entry for in the .changes/v1.14 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
radeksimko
force-pushed
the
backend-oss-bump-sdk
branch
from
51f28fd to
c83a6c1
Compare
|
Can you please review this and run the acceptance tests and provide output confirming they all still pass? Relatedly - can you help assess if this implies any end-user changes that we need to communicate via the Changelog? |
radeksimko
force-pushed
the
backend-oss-bump-sdk
branch
from
c83a6c1 to
60efcb2
Compare
|
@xingjiu Will you please review this PR and respond to my questions above? |
radeksimko
force-pushed
the
backend-oss-bump-sdk
branch
from
60efcb2 to
aacdebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: The later version is the earliest one which contains a license.
The patch still needs to be assessed regarding compatibility concerns and whether the acceptance tests are still passing after the bump. This is especially important since we are bumping the library from v1.9.3 to v2.1.1.
cc @xiaozhu36 Can you please review this and run the acceptance tests and provide output confirming they all still pass?
Relatedly - can you help assess if this implies any end-user changes that we need to communicate via the Changelog?
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry