fix: parse boolean env vars in S3 backend correctly #37940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietcgi
force-pushed
the
fix/s3-backend-fips-env-var-parsing
branch
from
d1d6240 to
b62d97a
Compare
Contributor
|
Thanks for this submission! The S3 backend is maintained by the AWS Provider team at HashiCorp, and IBM company. I have notified that team of your PR. Thanks again! |
|
@crw Thank you for getting the PR in the queue. Can we expedite this process? It has been a month since it's pending review. |
2 tasks
This is consistent with the `kind` used for previous breaking changes to S3 backend behavior.
jar-b
approved these changes
Jan 7, 2026
Member
jar-b
left a comment
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 202.097s
Member
|
Thank you for the contribution, @vietcgi! 👍 I modified the changelog entry to an upgrade note to align with how previous breaking changes to S3 backend behavior have been documented. |
dbanck
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
AWS_USE_FIPS_ENDPOINT=falseincorrectly enables FIPS endpoints because the code treats any non-empty string as true.This fixes
boolAttrDefaultEnvVarOkto properly parse "true"/"false" (case-insensitive), matching AWS SDK behavior.Fixes #37601