-
Notifications
You must be signed in to change notification settings - Fork 10.2k
variable and output deprecation #38001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,423
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5402a27 to
008e320
Compare
82b8b89 to
4c5d964
Compare
jbardin
reviewed
Dec 11, 2025
8b295d5 to
2746850
Compare
6c6a610 to
42cee35
Compare
3 tasks
fed3ea9 to
a9cb1c9
Compare
12 tasks
2746850 to
0cf6f0a
Compare
a9cb1c9 to
f877341
Compare
0cf6f0a to
af549ab
Compare
f877341 to
d79bf08
Compare
This was referenced Feb 2, 2026
Merged
jbardin
previously approved these changes
Feb 2, 2026
af549ab to
5d9ba5b
Compare
d79bf08 to
0ae6944
Compare
13fe64c to
d69c14d
Compare
Variables can be deprecated through the `deprecated` attribute. If set the variable will emit a diagnostic if a values is passed to it. This entails both root level and module variables. Outputs can be deprecated through the `deprecated` attribute as well. If set wherever the value is used a diagnostic will be emitted. Root level outputs can not be deprecated. The only acceptable usage of a deprecated output is another deprecated output (forwarding the deprecation to the module user). If modules not under your control have deprecation warnings you can add a `suppress_deprecations_warnigns` attribute to the module call in question to silence any deeply nested warnings.
I decided against it before since a lot of tests were panicing, but after consulting with peers I found out the tests were just minimally set up and before it was just fine without the current scope being set. Now we require it to be set as it would in a normal execution therefore I had to add a bit of setup to the tests
#38006 is dealing with resource deprecation
0ae6944 to
51c8cb5
Compare
jbardin
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Chain
Variables can be deprecated through the
deprecatedattribute. If set the variable will emit a diagnostic if a values is passed to it. This entails both root level and module variables.Outputs can be deprecated through the
deprecatedattribute as well. If set wherever the value is used a diagnostic will be emitted. Root level outputs can not be deprecated. The only acceptable usage of a deprecated output is another deprecated output (forwarding the deprecation to the module user).If modules not under your control have deprecation warnings you can add a
suppress_deprecations_warnignsattribute to the module call in question to silence any deeply nested warnings.For the full end-to-end implementation see #37795, this PR splits up that work into more reviewable chunks.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry