stacks: send progress events on failed provider configurations #38039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
TF-30650
branch
4 times, most recently
from
e7fb0db to
ec8cc22
Compare
|
Thank you so much for this work, Daniel 👏🏽 I'm having issues with running a local agent but had my coworker test it out for me. The data being returned is exactly what I'm looking for, for the UI. The correct icon is now displayed. I have to make a minor change on my end once this is released. |
dsa0x
reviewed
Jan 12, 2026
dsa0x
reviewed
Jan 12, 2026
matejrisek
reviewed
Jan 12, 2026
DanielMSchmidt
force-pushed
the
TF-30650
branch
from
e6ffbc2 to
4147ba9
Compare
DanielMSchmidt
force-pushed
the
TF-30650
branch
from
4147ba9 to
b901263
Compare
dsa0x
approved these changes
Jan 30, 2026
We need this information for stacks to forward the error to the progress stream as stacks expects everything that reports itself starting to e.g. plan to also finish either in an error or with success.
The events are non-deterministic
DanielMSchmidt
force-pushed
the
TF-30650
branch
from
b901263 to
501cc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TF-30650
Stacks expects for all resources / components that start the planning process to get an update once they are done. We send this through hooks in the success case but during plan we don't send updates if the plan failed. This means we don't know that a component / resource failed which leads to an incorrect UI produced by an incorrect set of progress messages.
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry