-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Add JSON Log Format Support to Vault CSI Provider #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khajanwolt
wants to merge
9
commits into
hashicorp:main
Choose a base branch
from
khajanwolt:feat-log-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
khajanwolt
commented
Oct 8, 2025
khajanwolt
commented
Oct 8, 2025
khajanwolt
commented
Oct 8, 2025
khajanwolt
commented
Oct 8, 2025
rednafi
reviewed
Oct 10, 2025
rednafi
approved these changes
Oct 10, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for JSON-formatted logging to the vault-csi-provider, enabling better integration with log aggregation systems like Datadog, ELK, and Splunk.
Changes
Core Implementation
New CLI Flag:
-log-formatflag with support forjsonandtextformatstextto maintain backward compatibilityJSON,TEXT, etc.)Files Modified:
main.go: ImplementedsetupLogger()function with format selection logicinternal/config/config.go: AddedLogFormatfield toFlagsConfigTesting
Unit Tests (
main_test.go):TestSetupLoggerFormat: Validates format configuration (JSON, TEXT, default)TestSetupLoggerFormatValidation: Tests case-insensitive validationTestSetupLoggerIntegration: End-to-end JSON output verificationTest Configuration:
test/bats/configs/vault-csi-provider-test.yaml: Kubernetes test manifesttest/bats/configs/test-app-with-vault-secrets.yaml: Sample app for mount testingUsage
Command Line
Kubernetes Deployment
Example Output
JSON Format
{"@level":"info","@message":"Logger initialized","@module":"vault-csi-provider","@timestamp":"2025-10-07T23:14:08.986Z","format":"json","level":"info"} {"@level":"info","@message":"Creating new gRPC server","@module":"vault-csi-provider","@timestamp":"2025-10-07T23:14:08.987Z"} {"@level":"info","@message":"Processing unary gRPC call","grpc.method":"/v1alpha1.CSIDriverProvider/MountSecretsStoreObjectContent","@timestamp":"..."}Manual Testing
Benefits
Migration Guide
For existing deployments wanting to switch to JSON logging:
-log-format=jsonin container argsRelated Issues
#177
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.