Add Kubernetes Client QPS and Burst Configuration#1013
Merged
Conversation
jaireddjawed
force-pushed
the
VAULT-33351/k8s-qps-burst-config
branch
from
768eeb8 to
7e3f6fd
Compare
…ded and not set by default
benashz
reviewed
Feb 20, 2025
…-burst-config' into VAULT-33351/k8s-qps-burst-config
benashz
reviewed
Feb 24, 2025
benashz
approved these changes
Mar 3, 2025
What does "many" mean? |
|
@luislongom For us we started to get issues at smth around 2k+ vault secrets in single cluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In clusters with many VaultStaticSecrets, the default Kubernetes client QPS of 5 and Burst of 10 is insufficient, leading it to throttle its communications with the Kubernetes API. This can cause brand-new deployments to roll out very slowly as their pods wait for their Kubernetes secrets to be created from their VaultStaticSecrets.
This PR addresses this by allowing users to change the Kubernetes client QPS and Burst values through environment variables/cli arguments and adds them as chart values.