-
Notifications
You must be signed in to change notification settings - Fork 133
Use Event Notifications to Update VaultDynamicSecrets Instantly #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: VAULT-40343/instant-updates-database-secrets
Are you sure you want to change the base?
Use Event Notifications to Update VaultDynamicSecrets Instantly #1159
Conversation
5061f2d to
cb21eea
Compare
0b365da to
574e918
Compare
efccc9b to
e756819
Compare
238ddf6 to
ae64913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have these unit tests which is also helpful, but can you also add an integration test for the event-watching functionality like you have in your other PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically, I think it'd be good to have an integration test that sets up the database and LDAP secrets engine and validates that events from those specific paths trigger the instant updates that we're expecting.
383711a to
ce15780
Compare
Description
This PR updates VaultDynamicSecrets in VSO when the corresponding secret in Vault has a relevant event occur on it.
Manual Testing
This PR was manually validated against the Azure Secrets Enterprise engine using both static and dynamic role configurations. Although event notifications have not yet been implemented across all secrets engines, the changes in this PR are forward-compatible: each plugin exposes the same generic event types (creds-create, static-creds-create, rotate). Once the remaining plugins add support for these notifications, VSO builds that include this PR will automatically work with them without requiring further modifications.
Setup Azure Configuration and K8s Authentication with Vault
Create VaultDynamicSecret CRD for static and dynamic secret
Get Original Credential details for dynamic role
Confirmed that client secret was different after new lease generated
Setup original dyanmic secret for static role and see original creds
Confirmed that the client secret was updated on an instant basis after rotating the secret