Skip to content

Conversation

@indietyp
Copy link
Member

Add MIR Builder Testing Support to HashQL Testing Documentation

🌟 What is the purpose of this PR?

This PR adds documentation and skill configuration for the MIR Builder testing approach in HashQL. It introduces a new testing strategy for MIR passes that allows programmatic construction of MIR bodies for unit testing.

🔍 What does this change?

  • Adds MIR Builder to the skill-rules.json description for HashQL testing
  • Updates the testing-hashql skill documentation to include MIR Builder as a fourth testing approach
  • Adds a comprehensive MIR Builder guide with examples and patterns
  • Updates the testing strategy table to include MIR pass unit tests

🛡 What tests cover this?

  • Documentation changes only, no tests required

❓ How to test this?

  1. Review the new MIR Builder guide to ensure it provides clear instructions
  2. Verify the skill rules correctly identify MIR Builder related keywords and patterns
  3. Check that the main skill documentation properly introduces the MIR Builder approach

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@cursor
Copy link

cursor bot commented Dec 18, 2025

PR Summary

Adds MIR Builder testing documentation, updates quick reference and references, and introduces a comprehensive guide for programmatic MIR test construction.

  • Documentation (HashQL testing skill):
    • MIR Builder Tests: New section in .claude/skills/testing-hashql/SKILL.md with purpose, usage, and a quick example; adds MIR pass unit tests to the quick reference table.
    • References: Updates reference links to resources/* in SKILL.md.
  • Guide:
    • Adds .claude/skills/testing-hashql/references/mir-builder-guide.md with detailed API, patterns, and test harness examples for building MIR bodies programmatically.

Written by Cursor Bugbot for commit 49ceb3a. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Dec 18, 2025
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from 9d400b7 to 18bd814 Compare December 18, 2025 12:25
@graphite-app graphite-app bot requested a review from a team December 18, 2025 12:33
@indietyp indietyp force-pushed the bm/be-251-hashql-create-transformation-benchmarks branch from ace4d3d to ac9b7f1 Compare December 19, 2025 00:06
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from 18bd814 to f1c535e Compare December 19, 2025 00:06
@indietyp indietyp force-pushed the bm/be-251-hashql-create-transformation-benchmarks branch from ac9b7f1 to 20bb74e Compare December 19, 2025 08:41
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from f1c535e to 5555534 Compare December 19, 2025 08:41
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from 5555534 to 73e5584 Compare December 19, 2025 08:54
@indietyp indietyp force-pushed the bm/be-251-hashql-create-transformation-benchmarks branch from 20bb74e to f480f90 Compare December 19, 2025 08:54
@indietyp indietyp force-pushed the bm/be-251-hashql-create-transformation-benchmarks branch from f480f90 to cf67552 Compare December 19, 2025 09:13
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from 73e5584 to a617bab Compare December 19, 2025 09:13
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from a617bab to d17cdce Compare December 19, 2025 14:31
@indietyp indietyp force-pushed the bm/be-251-hashql-create-transformation-benchmarks branch from cf67552 to eacd6c4 Compare December 19, 2025 14:31
Base automatically changed from bm/be-251-hashql-create-transformation-benchmarks to main December 19, 2025 16:15
@graphite-app graphite-app bot requested review from a team December 19, 2025 16:15
@indietyp indietyp force-pushed the bm/h-5877-hashql-update-skill-to-include-mir-builder branch from d17cdce to 49ceb3a Compare December 19, 2025 16:16
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2025

Merge activity

  • Dec 19, 4:16 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@indietyp indietyp added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 1404042 Dec 19, 2025
39 checks passed
@indietyp indietyp deleted the bm/h-5877-hashql-update-skill-to-include-mir-builder branch December 19, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area)

Development

Successfully merging this pull request may close these issues.

3 participants