-
Notifications
You must be signed in to change notification settings - Fork 110
BE-263: HashQL: add body! macro for declarative MIR construction in tests
#8229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bm/be-261-hashql-mir-administrative-reduction-pass
Are you sure you want to change the base?
BE-263: HashQL: add body! macro for declarative MIR construction in tests
#8229
Conversation
PR SummaryIntroduces a declarative DSL for MIR test construction and reorganizes the builder, significantly simplifying tests.
Written by Cursor Bugbot for commit 9530312. This will update automatically on new commits. Configure here. |
CodSpeed Performance ReportMerging #8229 will not alter performanceComparing Summary
Footnotes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bm/be-261-hashql-mir-administrative-reduction-pass #8229 +/- ##
======================================================================================
- Coverage 60.36% 59.78% -0.58%
======================================================================================
Files 1060 1066 +6
Lines 107742 106191 -1551
Branches 4478 4478
======================================================================================
- Hits 65039 63488 -1551
Misses 41963 41963
Partials 740 740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

🌟 What is the purpose of this PR?
Introduces the body! macro, a declarative DSL for constructing MIR bodies in tests. This replaces the verbose fluent builder API as the primary approach, making tests significantly more readable and concise (~940 net lines removed).
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
📹 Demo
Before (fluent builder):
After (body! macro):