Optimized check for already cracked hashes#1851
Open
Grr1337 wants to merge 4 commits intohashtopolis:masterfrom
Open
Optimized check for already cracked hashes#1851Grr1337 wants to merge 4 commits intohashtopolis:masterfrom
Grr1337 wants to merge 4 commits intohashtopolis:masterfrom
Conversation
Outsourced <check if hashes already cracked in other list> algorithm to SQL for better performance.
implemented prepared queries for input sanitization
Made Code formatting more pretty
bugfix - updated varchar length to 1024
Member
|
Thanks for your pull request. Please note that currently the big changes are happening in the dev branch and besides some bugfixes, the master will be updated at the point where the dev gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check, whether hashes from a new hashlist are already cracked in another list, got optimized.
Instead of searching each hashline in the database, the entire comparion got sourced out to the database.
A temporary table of the new hashes is created and via join cracked hashes will be determined.
This will speed up the comparison for lists of a bigger size.
I haven't done comprehensive performance tests, but with my hashtopolis hash table containing 10 million rows and a 500k lines hashfile, I achieved 40 seconds instead of 1 minute and 15 seconds.