Skip to content

Adding additional indexes#1917

Open
s3inlc wants to merge 4 commits intodevfrom
sql-indexes
Open

Adding additional indexes#1917
s3inlc wants to merge 4 commits intodevfrom
sql-indexes

Conversation

@s3inlc
Copy link
Member

@s3inlc s3inlc commented Feb 5, 2026

This adds all missing indexes on foreign keys in postgres (as in mysql they are created by default, but not in postgres).

Additionally, we create indexes on (isArchived, priority) for the tables Task and TaskWrapper, and on isArchived for the table Hashlist. Unfortunately, it is not possible to use IF NOT EXISTS on mysql create and drop index statements, therefore I had to create the stored procedures to avoid people having issues with the migrations if some index already exists or it tries to drop an index which does not exist.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds database indexes to improve query performance. It creates indexes on foreign key columns in PostgreSQL (which doesn't auto-index them unlike MySQL) and adds composite indexes on frequently queried columns (isArchived, priority) for both databases.

Changes:

  • Added indexes on 10 foreign key columns in PostgreSQL that are not automatically indexed
  • Added performance indexes on isArchived for Hashlist and composite (isArchived, priority) indexes for Task and TaskWrapper in both databases
  • Created stored procedures in MySQL to handle conditional index creation/dropping since MySQL doesn't support IF NOT EXISTS for index operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/migrations/postgres/20260205140244_indexes.sql Creates foreign key indexes and performance indexes for PostgreSQL using IF NOT EXISTS
src/migrations/mysql/20260205140244_indexes.sql Defines stored procedures for conditional index operations and creates performance indexes for MySQL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant