Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds database indexes to improve query performance. It creates indexes on foreign key columns in PostgreSQL (which doesn't auto-index them unlike MySQL) and adds composite indexes on frequently queried columns (isArchived, priority) for both databases.
Changes:
- Added indexes on 10 foreign key columns in PostgreSQL that are not automatically indexed
- Added performance indexes on isArchived for Hashlist and composite (isArchived, priority) indexes for Task and TaskWrapper in both databases
- Created stored procedures in MySQL to handle conditional index creation/dropping since MySQL doesn't support IF NOT EXISTS for index operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/migrations/postgres/20260205140244_indexes.sql | Creates foreign key indexes and performance indexes for PostgreSQL using IF NOT EXISTS |
| src/migrations/mysql/20260205140244_indexes.sql | Defines stored procedures for conditional index operations and creates performance indexes for MySQL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all missing indexes on foreign keys in postgres (as in mysql they are created by default, but not in postgres).
Additionally, we create indexes on (isArchived, priority) for the tables Task and TaskWrapper, and on isArchived for the table Hashlist. Unfortunately, it is not possible to use
IF NOT EXISTSon mysql create and drop index statements, therefore I had to create the stored procedures to avoid people having issues with the migrations if some index already exists or it tries to drop an index which does not exist.