refactor: Reduce intermediate allocations in encoding logic. #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few sources of memory inefficiency in the encode function:
This PR removes those allocations and also takes inspiration on efficient bytestring building from hsthrift.
Benchmarks: 20% improvement in encoding.
had to fix the benchmark to actually be meaningful for encode since it was always returning immediately. Also augmented the presidents dataset by replicating the columns until we had 20k of them to make sure the improvements weren't noise.
Before:
After: