Skip to content

Switch from XHR to Fetch API #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Switch from XHR to Fetch API #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad96c1c
Switch from XHR to Fetch API
kaol Sep 24, 2025
5353b29
bracket response and reader with releaselock and cancel, respectively
kaol Sep 24, 2025
382f93e
Wrap PromiseRejected exceptions from performFetch inside ConnectionError
kaol Sep 26, 2025
438092e
Use throwError instead of throwM for ConnectionError
kaol Sep 26, 2025
b411fd6
Remove MonadThrow and MonadCatch instances from Codensity JSM
kaol Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion servant-jsaddle.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ library
hs-source-dirs: src
ghc-options: -Wall
exposed-modules:
Servant.Client.Internal.JSaddleXhrClient
Servant.Client.JSaddle
other-modules:
Servant.Client.JSaddle.Internal.Client
Servant.Client.JSaddle.Internal.Fetch
Servant.Client.JSaddle.Internal.Types

-- Bundled with GHC: Lower bound to not force re-installs
-- text and mtl are bundled starting with GHC-8.4
Expand Down Expand Up @@ -71,6 +74,9 @@ library
, semigroupoids >=5.3.1 && <6.1
, string-conversions >=0.3 && <0.5
, transformers-base >=0.4.4 && <0.5
, servant
, mmorph
, kan-extensions

if impl(ghc >=8.0)
ghc-options: -Wno-redundant-constraints
Expand Down
319 changes: 0 additions & 319 deletions src/Servant/Client/Internal/JSaddleXhrClient.hs
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion src/Servant/Client/JSaddle.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module Servant.Client.JSaddle
, ClientM
, runClientM
, runClientM'
, withClientM

-- * Configuration
, ClientEnv(..)
Expand All @@ -16,5 +17,6 @@ module Servant.Client.JSaddle
, module Servant.Client.Core.Reexport
) where

import Servant.Client.Internal.JSaddleXhrClient
import Servant.Client.JSaddle.Internal.Client
import Servant.Client.JSaddle.Internal.Types
import Servant.Client.Core.Reexport
Loading