Add missing HasLink instance for DeepQuery (#1784)#1814
Merged
tchoutri merged 10 commits intohaskell-servant:masterfrom Apr 25, 2025
Merged
Add missing HasLink instance for DeepQuery (#1784)#1814tchoutri merged 10 commits intohaskell-servant:masterfrom
HasLink instance for DeepQuery (#1784)#1814tchoutri merged 10 commits intohaskell-servant:masterfrom
Conversation
Contributor
|
@kutyel Please rebase on HEAD, it seems to be fixed. :) |
kutyel
force-pushed
the
1784-haslink-instance-for-deepquery
branch
from
15e5d18 to
177a720
Compare
kutyel
force-pushed
the
1784-haslink-instance-for-deepquery
branch
2 times, most recently
from
83f138c to
594fa99
Compare
Contributor
Author
|
@tchoutri @clementd-fretlink build finally passed, feel free to review when you have time please 🙏🏻 🙌🏻 |
Contributor
|
looks good, maybe a few tests in https://github.com/haskell-servant/servant/blob/master/servant/test/Servant/LinksSpec.hs would be usehul |
kutyel
commented
Apr 22, 2025
tchoutri
reviewed
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution is based in @saurabhnanda's proposed solution, let me know if it needs further improving @clementd-fretlink @theophile-fl 🙏🏻 👀
Fixes #1784