Skip to content

Add Hashable instances for Data.Semigroup.{Sum,Product}. #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Hashable instances for Data.Semigroup.{Sum,Product}. #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Data/Hashable/Class.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,9 @@ instance Hashable1 NE.NonEmpty where
deriving newtype instance Hashable a => Hashable (Semi.Min a)
deriving newtype instance Hashable a => Hashable (Semi.Max a)

deriving newtype instance Hashable a => Hashable (Semi.Sum a)
deriving newtype instance Hashable a => Hashable (Semi.Product a)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to also add:

  • a @since <version number> for each new instance
  • an accompanying CHANGELOG entry

Though what version should be listed? (I notice that some repositories use "unreleased" as a placeholder for the eventual version number.)


-- | __Note__: Prior to @hashable-1.3.0.0@ the hash computation included the second argument of 'Arg' which wasn't consistent with its 'Eq' instance.
--
-- Since @hashable-1.5.0.0@, @hash (Semi.arg a _) = hash a@
Expand Down