Address deprecation warnings #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
force-pushed
the
sjakobi/issue505
branch
2 times, most recently
from
3d07305 to
498e663
Compare
...and a warning regarding the import of liftA2 Fixes #505
sjakobi
force-pushed
the
sjakobi/issue505
branch
from
498e663 to
dcca6a8
Compare
sjakobi
commented
Oct 5, 2025
Comment on lines
-161
to
+175
| lengthM :: MArray s a -> Int | ||
| lengthM mary = I# (sizeofSmallMutableArray# (unMArray mary)) | ||
| lengthM :: MArray s a -> ST s Int | ||
| lengthM (MArray ary) = ST $ \s -> | ||
| case getSizeofSmallMutableArray# ary s of | ||
| (# s', n #) -> (# s', I# n #) | ||
| {-# INLINE lengthM #-} | ||
|
|
||
| #if defined(ASSERTS) | ||
| -- | Unsafe. Only for use in the @CHECK_*@ pragmas. | ||
| unsafeLengthM :: MArray s a -> Int | ||
| unsafeLengthM mary = I# (sizeofSmallMutableArray# (unMArray mary)) | ||
| {-# INLINE unsafeLengthM #-} | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I would have preferred to completely remove any use of sizeofSmallMutableArray#, but I haven't been able to come up with a good solution that would allow us to keep the bounds CHECKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and a warning regarding the import of liftA2
Fixes #505
TODO:
lengthMinsideCHECK_BOUNDSandCHECK_LEchecks