Fix BitSeq Snoc instance #101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is covered by tests but it appears they are not functioning correctly- only single item lists are generated in
test/HaskellWorks/Data/RankSelect/BitSeqSpec.hs
. E.g. try printingbs
under snoc test:Using
resize
results in lists greater than 1 element and causes the test to fail (without this PR)I'm not sure on the correct fix for the tests as I am less familiar with hedgehog, but there seems to be some non obvious interaction with hedgehog 'Size'.