Add option tagAsContentsFieldName to TaggedObject SumEncoding #1142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for making aeson.
I've added a flag tagAsContentsFieldName which will allow encoding sum types as
This style is used in type encoding standards such as https://palantir.github.io/conjure/#/docs/spec/wire?id=_54-union-json-format.
Initially I was thinking to make
contentsFieldName
be aString -> String
and provide it the constructor name, which would be flexible enough to allow the default behavior ofconst "contents"
and also be able to dynamically use the constructor name (and even modify it), but this would break backcompat and also not be serializable to the TH implementation.Please let me know if you'd like any changes to the proposed API