Add allNullaryConstructorTagModifier option #1143
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, enums (all nullary contructors) are encoded differently than sum types.
For example, if I have
I might want to have these states encoded as
LAUNCHING
,LAUNCHED
,TERMINATED
,MARKED_FOR_DELETION
, respectively.However, using the existing
constructorTagModifier
is not satisfactory for this because I don't necessarily want my sum types, e.g.to be encoded the same way as an enum.
I've added an optional field
allNullaryConstructorTagModifier
(it'sMaybe
so that there's no behavior change to any existing usages of Aeson, in case someone is depending onconstructorTagModifier
also applying to all-nullary datatypes). When it'sNothing
, everything is the same as today. When it's non-Nothing
it's used instead ofconstructorTagModifier
for all-nullary datatypes, for the purposes of handling enums differently than sum types.Please let me know if you'd like any changes to the api