Skip to content

add placeholder boot files to simplify local installs#272

Merged
andreasabel merged 1 commit intohaskell:masterfrom
nicuveo:phantom-boot
Apr 6, 2025
Merged

add placeholder boot files to simplify local installs#272
andreasabel merged 1 commit intohaskell:masterfrom
nicuveo:phantom-boot

Conversation

@nicuveo
Copy link
Contributor

@nicuveo nicuveo commented Apr 5, 2025

This PR is a small quality of life change.

As part of the tarball creation process, the Makefile sdist command creates two new files, src/Scan.x.boot and src/Parser.y.boot. Since we want them included in the resulting tarball, they are also listed in the extra-source-files in alex.cabal. This creates a bit of friction for developers: as those files do not exist in the repo itself, calls to cabal install fail.

To fix this, this PR adds two empty placeholder files. They do not impact any other workflow, but now allow cabal install to succeed.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, seems to work!

@andreasabel andreasabel merged commit 13839ec into haskell:master Apr 6, 2025
20 checks passed
@nicuveo nicuveo deleted the phantom-boot branch April 6, 2025 23:18
@andreasabel andreasabel added this to the 3.5.4.0 milestone Aug 3, 2025
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 21, 2025
## Changes in 3.5.4.0

* Fix [issue #277](haskell/alex#277):
  compatibility of generated code with `{-# LANGUAGE ImpredicativeTypes #-}`,
  thanks Nadia Yvette Chambers!
* Simplify `cabal install` ([PR #272](haskell/alex#272)),
  thanks Antoine Leblanc!
* Document `examples/words.x`, thanks Piotr Justyna!
* Tested with GHC 8.0 - 9.12.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants