Better Tests and Benchmarks for Float and Double Builders #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
clyring
reviewed
Feb 27, 2024
|
@clyring I have made some changes and comments since your last review. |
|
Thanks for the ping. Sorry for being so slow on this round of review--I will take another look this weekend. |
clyring
reviewed
May 20, 2024
clyring
reviewed
Jun 5, 2024
BebeSparkelSparkel
force-pushed
the
realfloat-bench
branch
from
88d4e16 to
c63ddc2
Compare
clyring
reviewed
Jun 20, 2024
BebeSparkelSparkel
force-pushed
the
realfloat-bench
branch
from
de52282 to
fef5f6a
Compare
|
I do not understand the build error for ppc64le |
|
@BebeSparkelSparkel you probably need to extend this line: bytestring/.github/workflows/ci.yml Line 138 in 0e0526b |
BebeSparkelSparkel
force-pushed
the
realfloat-bench
branch
from
15487d2 to
49c46d1
Compare
|
That fixed it! |
BebeSparkelSparkel
force-pushed
the
realfloat-bench
branch
from
ec3d5fc to
fef5f6a
Compare
…lue since order changes the bench mark
Co-authored-by: Matthew Craven <[email protected]>
Co-authored-by: Matthew Craven <[email protected]>
Co-authored-by: Matthew Craven <[email protected]>
using non base casting functions floating point data does not depend on intData better generation of specials fixed DoubleSmall bench using the wrong test data
Co-authored-by: Matthew Craven <[email protected]>
BebeSparkelSparkel
force-pushed
the
realfloat-bench
branch
from
fef5f6a to
2a2cdc4
Compare
|
@clyring rebased and solved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests fail from an existing bug detailed in #641