Skip to content

Conversation

geekosaur
Copy link
Collaborator

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with

cabal build all -c 'time>=1.15' --allow-newer='unix:time,directory:time,tree-diff:time,hackage-security:time,aeson:time,time-compat:time,nothunks:time,text-iso8601:time,tar:time,HTTP:time'

@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Aug 4, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Aug 4, 2025
@ulysses4ever
Copy link
Collaborator

Thank you for checking, @Bodigrim.

@geekosaur maybe we should do this routinely when updating bounds to our dependencies.

@geekosaur
Copy link
Collaborator Author

Probably yes; I forgot this time. I wonder if there's some way to automate this (we already have the appropriate inputs, but they can only be used with workflow_dispatch). Maybe a label, but then we need some way to pass it the appropriate inputs.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 6, 2025
mergify bot added a commit that referenced this pull request Aug 6, 2025
mergify bot added a commit that referenced this pull request Aug 6, 2025
@mergify mergify bot merged commit b140dca into haskell:master Aug 6, 2025
55 checks passed
@bgamari
Copy link
Contributor

bgamari commented Aug 7, 2025

Can we backport this to 3.16?

@ulysses4ever
Copy link
Collaborator

@mergify backport 3.16

Copy link
Contributor

mergify bot commented Aug 8, 2025

backport 3.16

✅ Backports have been created

@ulysses4ever
Copy link
Collaborator

@bgamari is it necessary for the GHC 9.14 release? we planned a release of cabal only after 9.14 is out

@mergify mergify bot mentioned this pull request Aug 8, 2025
2 tasks
mergify bot added a commit that referenced this pull request Aug 8, 2025
@bgamari
Copy link
Contributor

bgamari commented Aug 11, 2025

@bgamari is it necessary for the GHC 9.14 release? we planned a release of cabal only after 9.14 is out

Yes it is.

@geekosaur
Copy link
Collaborator Author

Perhaps more to the point: is this needed for the alpha? I think the original plan was to test against the alpha and fix anything else needed for it to work. Failing that, we should at least have a branch to test against.

@ulysses4ever
Copy link
Collaborator

I first thought we might need another release, but that's not necessarily the case: a revision of 3.16.0.0 (which, the release, is already on Hackage), hopefully, would be enough? @bgamari

@geekosaur
Copy link
Collaborator Author

geekosaur commented Aug 11, 2025

Except that libraries/Cabal is bundled with ghc, so that probably needs to have an updated cabal file. Especially if it's expected to build with the bundled libraries/time.

@bgamari
Copy link
Contributor

bgamari commented Aug 11, 2025

As @geekosaur said, GHC needs an upstream git commit as Cabal is a boot library included in the GHC tree via submodule. Moreover, ideally a revision should not pushed to Hackage until the corresponding commit is committed to the appropriate release branch.

Regardless, the backport has happened in #11137 so I don't think anything more is needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants