-
Notifications
You must be signed in to change notification settings - Fork 720
update time
to 1.15
#11127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update time
to 1.15
#11127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with
cabal build all -c 'time>=1.15' --allow-newer='unix:time,directory:time,tree-diff:time,hackage-security:time,aeson:time,time-compat:time,nothunks:time,text-iso8601:time,tar:time,HTTP:time'
Thank you for checking, @Bodigrim. @geekosaur maybe we should do this routinely when updating bounds to our dependencies. |
Probably yes; I forgot this time. I wonder if there's some way to automate this (we already have the appropriate inputs, but they can only be used with |
Can we backport this to 3.16? |
@mergify backport 3.16 |
✅ Backports have been created
|
@bgamari is it necessary for the GHC 9.14 release? we planned a release of cabal only after 9.14 is out |
Backport #11127: update `time` to 1.15
Yes it is. |
Perhaps more to the point: is this needed for the alpha? I think the original plan was to test against the alpha and fix anything else needed for it to work. Failing that, we should at least have a branch to test against. |
I first thought we might need another release, but that's not necessarily the case: a revision of 3.16.0.0 (which, the release, is already on Hackage), hopefully, would be enough? @bgamari |
Except that |
As @geekosaur said, GHC needs an upstream Regardless, the backport has happened in #11137 so I don't think anything more is needed here. |
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: