Follow hlint suggestion: use infix #11143
Merged
+31
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philderbeast
force-pushed
the
hlint/use-infix
branch
from
c84ab43 to
441a17b
Compare
Bodigrim
approved these changes
Aug 9, 2025
geekosaur
approved these changes
Aug 9, 2025
- Follow hlint suggestion: Use infix for elem and notElem - Follow hlint suggestion: Use infix for isPrefixOf - Follow hlint suggestion: Use infix for set ops, union and intersect - Add extensionIn - Reuse hasThreaded
philderbeast
force-pushed
the
hlint/use-infix
branch
from
441a17b to
906d2de
Compare
ulysses4ever
approved these changes
Aug 9, 2025
mergify
bot
added
the
ready and waiting
|
@mergify refresh |
✅ Pull request refreshed |
|
Does the bot refresh reset the countdown timer or is this pull request stuck? If the former can I please add [merge delay passed] label? |
|
Quick glance makes me think you said "mergify refresh" a tiny bit before the 48 hours from the last push lapsed. Maybe it decided to reset the timer then. I'd wait more. Sadly, there's no reliable way to check the timer, afaik. |
Thanks @ulysses4ever. Yes that's what I'm thinking too. At 3 days now, we've definitely passed the 2 day delay. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ff7c123 |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores the "Use infix" warning so that it will be picked up by our CI linting.
A follow on from #11135, from a code review suggestion from @ulysses4ever to use
notEleminfix, #11135 (comment).After following the suggestions, I made a couple of additional changes, adding an
extensionInfunction and reusing thehasThreadedfunction.I'll squash commits before applying the merge label if this pull request is approved.