Skip to content

Fix incomplete-record-selection warning in cabal-install #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix incomplete-record-selection warning in cabal-install #11208

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
577c848
Fix incomplete-record-selection warning in cabal-install
sgillespie Sep 5, 2025
c25ab80
Add a comment clarifying repoTarballPkgsWithMetadata are all SecureRepos
sgillespie Sep 18, 2025
2b0c150
Refactor getPackageSourceHashes in cabal-install
sgillespie Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cabal-install/src/Distribution/Client/ProjectPlanning.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,8 @@ getPackageSourceHashes verbosity withRepoCtx solverPlan = do
]
| (repo, pkgids) <-
map (\grp@((repo, _) :| _) -> (repo, map snd (NE.toList grp)))
. NE.groupBy ((==) `on` (remoteRepoName . repoRemote . fst))
. sortBy (compare `on` (remoteRepoName . repoRemote . fst))
. NE.groupBy ((==) `on` (fmap remoteRepoName . maybeRepoRemote . fst))
. sortBy (compare `on` (fmap remoteRepoName . maybeRepoRemote . fst))
$ repoTarballPkgsWithMetadata
]

Expand Down
Loading