Skip to content

Expand ${pkgroot} variable when reading haddock-html field from ghc-pkg #11218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expand ${pkgroot} variable when reading haddock-html field from ghc-pkg #11218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cabal/src/Distribution/Simple/Program/HcPkg.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ mungePackagePaths pkgroot pkginfo =
, libraryDynDirs = mungePaths (libraryDynDirs pkginfo)
, frameworkDirs = mungePaths (frameworkDirs pkginfo)
, haddockInterfaces = mungePaths (haddockInterfaces pkginfo)
, haddockHTMLs = mungeUrls (haddockHTMLs pkginfo)
, haddockHTMLs = mungePaths (mungeUrls (haddockHTMLs pkginfo))
}
where
mungePaths = map mungePath
Expand Down
6 changes: 6 additions & 0 deletions changelog.d/pr-11218.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
synopsis: Fix links to installed documentation when running `cabal haddock`
packages: Cabal
prs: #11218

Links to installed documentation (i.e. for base) from generated haddock should
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would explain why here (that is, mention ${pkgroot}).

I'm not sure if this might count as significant. Artem/others?

now work.
Loading