Skip to content

Conversation

geekosaur
Copy link
Collaborator

Someone (I won't claim it wasn't me) swapped digits in the dependency for cabal-install. But it's correct for the later tests, which makes me think it was a typo.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Someone (I won't claim it wasn't me) swapped digit in the dependency for
cabal-install. But it's correct for the later tests, which makes me
think it was a typo.
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Oct 1, 2025

git-blame tells me that the current bound was committed in 2018 4aea51a, which is 1+ year before network-uri-2.6.2.0 was released (https://hackage.haskell.org/package/network-uri-2.6.2.0). So, I doubt 2.6.0.2 is a typo.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the light of the corresponding issue, this looks necessary.

I wish we had a --prefer-oldest CI configuration...

@geekosaur
Copy link
Collaborator Author

I'm still poking at using special comments to trigger customized CI runs; if I can figure it out (currently it looks like I'll need or at least really want a separate job triggered only on comments, since otherwise there'll have to be magic conditionals all over the place) I could probably add one. Can't be too general, though, since it has to be written to the project file instead of passed as an option.

@geekosaur
Copy link
Collaborator Author

Blame won't really tell you anything here, since git goes by diffs and someone accidentally re-typing the same bound won't show up as a change.

@mniip
Copy link

mniip commented Oct 1, 2025

I think network-uri-2.6.0.2 was chosen as a lower bound because that's where instance NFData URI was introduced, which cabal-install uses

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 1, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 1, 2025
@geekosaur
Copy link
Collaborator Author

@mergify backport 3.16

Copy link
Contributor

mergify bot commented Oct 1, 2025

backport 3.16

✅ Backports have been created

@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Oct 3, 2025
mergify bot added a commit that referenced this pull request Oct 3, 2025
@mergify mergify bot merged commit 2c54d05 into haskell:master Oct 3, 2025
240 of 241 checks passed
@mergify mergify bot removed the queued label Oct 3, 2025
@mergify mergify bot mentioned this pull request Oct 3, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal-install dependency on network-uri is too loose
4 participants