Skip to content

Conversation

@ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Dec 21, 2025

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever
Copy link
Collaborator Author

the release isn't in ghcup yet, so it's a draft

@ulysses4ever ulysses4ever marked this pull request as draft December 21, 2025 19:11
@mpickering mpickering force-pushed the ulysses4ever-patch-3 branch from a801934 to f41bbf7 Compare January 5, 2026 11:24
@mpickering
Copy link
Collaborator

I have rebased.

@ulysses4ever ulysses4ever marked this pull request as ready for review January 5, 2026 12:32
@ulysses4ever ulysses4ever marked this pull request as draft January 5, 2026 12:33
@ulysses4ever ulysses4ever marked this pull request as ready for review January 5, 2026 12:35
@ulysses4ever
Copy link
Collaborator Author

Thanks! Ready for review then. The 902 failure is unrelated

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jan 5, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jan 6, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2026

Merge Queue Status

✅ The pull request has been merged at 44a12e1

This pull request spent 1 hour 51 minutes 48 seconds in the queue, including 1 hour 41 minutes 3 seconds running CI.
The checks were run on draft #11398.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Jan 8, 2026
@mergify mergify bot merged commit 9f004e7 into master Jan 8, 2026
176 checks passed
@mergify mergify bot deleted the ulysses4ever-patch-3 branch January 8, 2026 23:41
@mergify mergify bot removed the queued label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants