-
Notifications
You must be signed in to change notification settings - Fork 725
Don't use lists in footnotes #11378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use lists in footnotes #11378
Conversation
geekosaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually consider that a bug they should fix, but it sounds like that's unlikely.
|
I think the text should use "First, ... Second, ... Third, ..." or something |
1a39ff8 to
64958f7
Compare
@ulysses4ever I numbered the sentences. |
|
@philderbeast it'd be more idiomatic to use the actual words "first", etc. instead of numbers. |
I asked Google and its AI didn't suggest that. My question for it was "how to number bullet points as sentences within a paragraph". |
|
My take on this is that things like "1." or "(a)" not in a proper list are fine for casual writing, but the words should be used within sentences for more formal writing such as in manuals. I should probably add that I'm from an older school and notions of what's acceptable in formal writing may have shifted a bit, driven in particular by wider use of casual writing starting with email. |
|
"it" became a bit ambiguous when the list was split into separate sentences, I think. |
3995ced to
3384606
Compare
ulysses4ever
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! One last ask: could you wrap build-depends into code fences (double backticks in RST i think?..).
|
Rebasing on master should help with CI |
a8c2f43 to
a46387c
Compare
|
No need to backport this one is there? |
- Number the point sentences - Use first, next and finally - Replace .using Nix-style with with etc - Replace it with build-depends - Use code style for build-depends Co-Authored-By: Artem Pelenitsyn <[email protected]>
a46387c to
9f85732
Compare
|
I opted to squash manually but left the [squash+merge me] label. |
|
theoretically, we could bacckport to 3.16 and then push a new tag that RTD would pick up and update the docs for 3.16... i don't have energy for that but if someone has, we could probably do it (tags will have to be done by maintainers, of course...) |
Merge Queue Status✅ The pull request has been merged at 9f85732 This pull request spent 1 hour 58 minutes 9 seconds in the queue, including 1 hour 47 minutes 2 seconds running CI. Required conditions to merge
|
Fixes #11246. With the read the docs theme at versions
>=0.18we can't use lists within footnotes. I removed the list and put its elements inline as sentences within the footnote paragraph.