Skip to content

cabal check: Fix broken link to docs for description/synopsis #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Jan 8, 2026
Merged

cabal check: Fix broken link to docs for description/synopsis #11391

mergify merged 1 commit into from
Jan 8, 2026
+4 −3

Conversation

@pmiddend
Copy link
Collaborator

@pmiddend pmiddend commented Jan 6, 2026 •
edited
Loading

I can't 100% tell if the new URL I added is the exact same as the previous one, but it must be. One could also link to the concrete section (on synopsis: ... or description: ...) instead, but this seems okay to me.

ulysses4ever
ulysses4ever approved these changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We really ought to have a broken-links checker for the manual.

@ulysses4ever ulysses4ever added documentation merge me Tell Mergify Bot to merge re: readthedocs Concerning hosting documentation on `readthedocs` labels Jan 6, 2026
@pmiddend
Copy link
Collaborator Author

pmiddend commented Jan 6, 2026

Not sure why this validation job fails. Is it flaky? Did I do something wrong?

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jan 6, 2026

@pmiddend I'm sorry that's on us: the 902 job failed right around the New Year, so we're getting to fix it only now (#11388). 967 is indeed a known heisenbug related to network access from github runners.

I'll make sure your patch lands, thanks for the contribution!

@ulysses4ever ulysses4ever force-pushed the fix-package-description-docs branch from 5fa1aa9 to 978a95a Compare January 6, 2026 15:00
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jan 6, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at 978a95a

This pull request spent 1 hour 51 minutes 19 seconds in the queue, including 1 hour 39 minutes 47 seconds running CI.
The checks were run on draft #11397.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Jan 8, 2026
@mergify
Merge of #11391
3db5dee
@mergify mergify bot mentioned this pull request Jan 8, 2026
Closed
86 tasks
mergify bot added a commit that referenced this pull request Jan 8, 2026
@mergify
Merge of #11391
042b17d
@mergify mergify bot merged commit bf87ddb into haskell:master Jan 8, 2026
203 of 205 checks passed
@mergify mergify bot removed the queued label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees

No one assigned

Labels

documentation merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: readthedocs Concerning hosting documentation on `readthedocs` ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmiddend @ulysses4ever @ffaf1