Skip to content

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Mar 7, 2025

While working on haskell/filepath#250 I realized I need to inline insane amounts of code. Then I found out that directory basically already has what we need in internal modules. My understanding is that this would fit well in directory API, since it also deals with XDG. So PATH doesn't seem to be far fetched.

This would also allow me to deprecate the problematic getSearchPath in filepath.

@hasufell hasufell requested a review from Rufflewind March 7, 2025 08:29
@hasufell hasufell force-pushed the getPath branch 4 times, most recently from f102bf0 to c3b8ed4 Compare March 7, 2025 08:52
@hasufell
Copy link
Member Author

hasufell commented Mar 8, 2025

As a sidenote: the identifier is named getPath as to not clash with System.FilePath.getSearchPath since they're often imported together

@Rufflewind
Copy link
Member

Rufflewind commented Mar 9, 2025

I will probably rename this to something more specific like getExecSearchPath to avoid confusion and possible conflicts with user-defined functions.

@Rufflewind Rufflewind self-assigned this Mar 9, 2025
@hasufell
Copy link
Member Author

hasufell commented Mar 9, 2025

I will probably rename this to something more specific like getExecSearchPath to avoid confusion and possible conflicts with user-defined functions.

Makes sense.

@Rufflewind Rufflewind merged commit 812696a into haskell:master Mar 9, 2025
10 checks passed
@Rufflewind
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants