Skip to content

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Aug 19, 2025

No description provided.

@jhrcek
Copy link
Collaborator Author

jhrcek commented Aug 19, 2025

Hey @develop7
trying to work towards publishing 9.10.2 images on dockerhub.
but all the buster stuff (past End of Life) is failing to build.

What would you recommend doing with those:

  1. Just commenting out all buster-based images in CI config (viz commit below)? Or..
  2. 1 + removing all buster images from the repo?

@jhrcek jhrcek force-pushed the jhrcek/ghc-9.10.2 branch from 174839c to 0fc4962 Compare August 19, 2025 10:23
@@ -26,50 +26,26 @@ jobs:
strategy:
fail-fast: false
matrix:
ghc: ['9.12.2', '9.10.1', '9.8.4', '9.6.7', '9.4.8', '9.2.8', '9.0.2']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing all older GHCs from here, as those only have Buster based images that no longer build.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, you could still use older bindists on newer debian. Worked for aarch64 before, must work for x86_64. anyway, it's beyond the scope of this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the haskell community is on ghc 9.6.7+.
I would prefer not adding older GHCs with newer debians unless there's popular demand for it.

ghc: ['9.12.2', '9.10.1', '9.8.4', '9.6.7', '9.4.8', '9.2.8', '9.0.2']
deb: ['buster', 'slim-buster']
ghc: ['9.12.2', '9.10.2', '9.8.4', '9.6.7']
deb: ['bullseye', 'slim-bullseye']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Buster is no longer buildable, switching the "default" debian to the next release which is still supported.

@develop7
Copy link
Collaborator

First of all, thank you for being ahead of the issue and creating the PR.

Buster-wise, I will merge this PR as long as it's ready for you.

Dealing with buster images warrants for separate PR and I'd suggest to extract buster-based images to separate, er, workflow, or at least allow these to fail

@jhrcek jhrcek requested a review from develop7 August 19, 2025 10:31
@develop7 develop7 marked this pull request as ready for review August 19, 2025 10:32
@jhrcek jhrcek changed the title feat: bump ghc 9.10 to 9.10.2 Remove no longer building buster based images from CI config Aug 19, 2025
@jhrcek jhrcek force-pushed the jhrcek/ghc-9.10.2 branch from aaca849 to 11bf04b Compare August 19, 2025 10:40
@jhrcek
Copy link
Collaborator Author

jhrcek commented Aug 19, 2025

Ok, let me turn this PR into "disabling buster based images in CI" first, because I don't like merging PRs with failing jobs.

Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.12@bullseye is gone now,

This reverts commit 848f659.
@develop7 develop7 self-requested a review August 19, 2025 14:01
Copy link
Collaborator

@develop7 develop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@develop7 develop7 merged commit 6357cd4 into master Aug 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants