-
Notifications
You must be signed in to change notification settings - Fork 38
Remove no longer building buster based images from CI config #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @develop7 What would you recommend doing with those:
|
174839c
to
0fc4962
Compare
@@ -26,50 +26,26 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
ghc: ['9.12.2', '9.10.1', '9.8.4', '9.6.7', '9.4.8', '9.2.8', '9.0.2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing all older GHCs from here, as those only have Buster based images that no longer build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, you could still use older bindists on newer debian. Worked for aarch64 before, must work for x86_64. anyway, it's beyond the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the haskell community is on ghc 9.6.7+.
I would prefer not adding older GHCs with newer debians unless there's popular demand for it.
ghc: ['9.12.2', '9.10.1', '9.8.4', '9.6.7', '9.4.8', '9.2.8', '9.0.2'] | ||
deb: ['buster', 'slim-buster'] | ||
ghc: ['9.12.2', '9.10.2', '9.8.4', '9.6.7'] | ||
deb: ['bullseye', 'slim-bullseye'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Buster is no longer buildable, switching the "default" debian to the next release which is still supported.
First of all, thank you for being ahead of the issue and creating the PR. Buster-wise, I will merge this PR as long as it's ready for you. Dealing with buster images warrants for separate PR and I'd suggest to extract buster-based images to separate, er, workflow, or at least allow these to fail |
aaca849
to
11bf04b
Compare
Ok, let me turn this PR into "disabling buster based images in CI" first, because I don't like merging PRs with failing jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.12@bullseye is gone now,
This reverts commit 848f659.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
No description provided.