Skip to content

hackage-server/BuildReports: Fix parsing of flag assignments#1384

Merged
gbaz merged 1 commit intomasterfrom
wip/T1383
Apr 20, 2025
Merged

hackage-server/BuildReports: Fix parsing of flag assignments#1384
gbaz merged 1 commit intomasterfrom
wip/T1383

Conversation

@bgamari
Copy link
Copy Markdown
Contributor

@bgamari bgamari commented Apr 19, 2025

Eventually this should really just use the Cabal FlagAssignment type
but here I have opted to instead just stay with the status quo and
update the parser.

Fixes #1383.

Eventually this should really just use the Cabal `FlagAssignment` type
but here I have opted to instead just stay with the status quo and
update the parser.

Fixes #1383.
@gbaz gbaz merged commit 4e2b5c6 into master Apr 20, 2025
5 of 13 checks passed
@bgamari bgamari deleted the wip/T1383 branch April 21, 2025 12:50
bgamari added a commit to bgamari/hackage-doc-builder-config that referenced this pull request Apr 23, 2025
As cabal-install-3.12 produces build reports using new FlagAssignment
syntax which hackage-server doesn't understand.

This will be fixed by haskell/hackage-server#1384
@bgamari
Copy link
Copy Markdown
Contributor Author

bgamari commented Apr 23, 2025

Strangely, even cabal-install-3.10.3.0 (which the old doc builder deployment still uses) emits this syntax. See, for instance, the output of

$ cabal unpack SHA-1.5.0.0; cd SHA-1.5.0.0; cabal v1-install --flag=+exe --build-summary=hi .; grep flags hi
...
flags:           +exe -test

I don't understand how the builder was previously working at all in light of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build reports endpoint cannot parse reports generated by cabal-install 3.12

2 participants