Skip to content

Fix exporting operator pattern synonym #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Fix exporting operator pattern synonym #4420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b0d729
Add tests for export unused top binding code action
pbrinkmeier Oct 11, 2024
a4c15b1
Parenthesize symbolic pattern synonyms in add export code action
pbrinkmeier Oct 11, 2024
6642baa
Refactor printExport
pbrinkmeier Oct 11, 2024
a8eb8b5
Remove superfluous tests
pbrinkmeier Oct 11, 2024
8263913
Revert implementation to correct one
pbrinkmeier Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ suggestExportUnusedTopBinding srcOpt ParsedModule{pm_parsed_source = L _ HsModul

printExport :: ExportsAs -> T.Text -> T.Text
printExport ExportName x = parenthesizeIfNeeds False x
printExport ExportPattern x = "pattern " <> x
printExport ExportPattern x = "pattern " <> parenthesizeIfNeeds False x
printExport ExportFamily x = parenthesizeIfNeeds True x
printExport ExportAll x = parenthesizeIfNeeds True x <> "(..)"

Expand Down
13 changes: 13 additions & 0 deletions plugins/hls-refactor-plugin/test/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3413,6 +3413,19 @@ exportUnusedTests = testGroup "export unused actions"
, "module A (pattern Foo) where"
, "pattern Foo a <- (a, _)"
]
, testSession "unused pattern synonym operator" $ template
[ "{-# OPTIONS_GHC -Wunused-top-binds #-}"
, "{-# LANGUAGE PatternSynonyms #-}"
, "module A () where"
, "pattern x :+ y = (x, y)"
]
(R 3 0 3 12)
"Export ‘:+’"
[ "{-# OPTIONS_GHC -Wunused-top-binds #-}"
, "{-# LANGUAGE PatternSynonyms #-}"
, "module A (pattern (:+)) where"
, "pattern x :+ y = (x, y)"
]
, testSession "unused data type" $ template
[ "{-# OPTIONS_GHC -Wunused-top-binds #-}"
, "module A () where"
Expand Down
Loading