Skip to content

Fix warning on startup when "initializationOptions": null #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix warning on startup when "initializationOptions": null #4498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc0da8a
Fig warning on startup when `"initializationOptions": null`
dschrempf Feb 16, 2025
310483a
Ignore dir-locals.el (Emacs)
dschrempf Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ cabal.project.local

.tasty-rerun-log

# emacs
/.dir-locals.el

# shake build information
_build/

Expand Down
1 change: 1 addition & 0 deletions hls-plugin-api/src/Ide/Plugin/Config.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import Ide.Types
-- | Given a DidChangeConfigurationNotification message, this function returns the parsed
-- Config object if possible.
getConfigFromNotification :: IdePlugins s -> Config -> A.Value -> Either T.Text Config
getConfigFromNotification _ defaultValue A.Null = Right defaultValue
getConfigFromNotification plugins defaultValue p =
case A.parse (parseConfig plugins defaultValue) p of
A.Success c -> Right c
Expand Down
Loading