Add Code Action for adding a module to your project's cabal file #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
3 times, most recently
from
61bf7ee to
16bef12
Compare
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
from
16bef12 to
234cb09
Compare
|
@VeryMilkyJoe please upgrade to the latest commit of |
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
2 times, most recently
from
c40661e to
56144e4
Compare
Done and all tests that matter are green :) |
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
from
56144e4 to
6a950f1
Compare
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
6 times, most recently
from
c93ce2a to
47a6dca
Compare
VeryMilkyJoe
commented
Aug 5, 2025
VeryMilkyJoe
commented
Aug 5, 2025
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Command.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Types.hs
Outdated
Show resolved
Hide resolved
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Types.hs
Outdated
Show resolved
Hide resolved
|
In my opinion, this is in a merge ready state, unless anyone wants to look over it again 🙃 @fendor? |
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
4 times, most recently
from
c508085 to
ec0b496
Compare
fendor
approved these changes
Aug 7, 2025
plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal/CabalAdd/Command.hs
Outdated
Show resolved
Hide resolved
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
from
ec0b496 to
b2cfba6
Compare
For diagnostics complaining about the current module being unknown, we now offer code actions to add the module to any possible field in the responsible cabal file. Additionally, refactor the cabal-plugin into smaller modules and refactor the add-package feature to have some shared functions to be used for both add-package and add-module.
VeryMilkyJoe
force-pushed
the
feature/cabal-add-module
branch
from
b2cfba6 to
5876af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For diagnostics complaining about the current haskell module being unknown, we now offer all possible code actions to add the module to a field in the responsible cabal file.
Additionally, this PR refactors the cabal-plugin into smaller modules and also refactors the add-package feature to have some shared functions to be used for both add-package and add-module.
Thank you to @Bodigrim for the changes in
cabal-addthat made it possible to implement this feature without a huge amount of pain!Screencast.From.2025-06-07.17-49-54.mp4