Skip to content

Conversation

crtschin
Copy link
Contributor

Closes #4650

This ended up being a bigger change than I intended. Some notes:

  • I followed the groupings in the linked issue per format.
  • I removed the regex-based approach for matching formats for simple string-matching. I didn't quite see an easy way to reuse it, as underscores can appear in any position in a literal. Makes it so we get the "fixing" functionality for semi-free.
    • I did reuse the regex's in the tests.
  • NumericUnderscores is another extension, now the code action can add multiple of these.

@crtschin crtschin requested a review from drsooch as a code owner August 30, 2025 12:30
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution, this looks great to me!

Waiting for another review by @drsooch who is the maintainer of this plugin :)

@fendor fendor added the status: needs review This PR is ready for review label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code action to introduce _ in number literals
2 participants