-
-
Notifications
You must be signed in to change notification settings - Fork 407
Use edit-distance to fix typos in cabal fields #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use edit-distance to fix typos in cabal fields #4722
Conversation
3c4d9d8
to
53bf792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for taking care of this!
plugins/hls-cabal-plugin/test/testdata/code-actions/FieldSuggestionsTypos.cabal
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much!
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
201c9b7
to
d74eb5c
Compare
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
I'm not sure I understand why the test is failing. It doesn't look related to my changes. I can reproduce this locally, but the same test also fails on master on my machine. I tried checking the failing test, but also don't see why it could be flaky though (if flaky tests are a thing in this repository). I might need some pointers. |
@crtschin Don't worry about it, most of our tests are unfortunately flaky one way or another :) I restarted the job, should be fine. |
Closes #4357.
This adds a pretty simple function for calculating the edit distance between two strings and uses it to score suggestions in completion lists. Some
Matcher
that's used in scoring texts intoCompleterData
. Couldn't really massage that into theweightedConstantCompleter
that's used for licenses.