Merged
Conversation
f2ae87e to
bdebf48
Compare
Bodigrim
approved these changes
Feb 24, 2025
Member
Author
(Thanks to HLS for the suggestions.) This should harden the code base against ecosystem changes like what happened for random-1.3. QuickCheck and HUnit are not imported qualified everywhere yet, because HLS failed on some modules.
7396a74 to
44b4af2
Compare
Outcome of a discussion with Simon Hengel.
Member
Author
|
I had a phone conversation with @sol resulting in a new README. |
Bodigrim
reviewed
Feb 26, 2025
|
|
||
| - [hspec](https://hackage.haskell.org/package/hspec) | ||
| - [tasty](https://hackage.haskell.or/package/tasty) | ||
|
|
There was a problem hiding this comment.
It would be helpful to guide users how to migrate to modern frameworks. Here is an instruction for tasty:
### Migration to `tasty`
The following steps are sufficient for the majority of packages:
* Replace packages in `build-depends`:
* `test-framework` -> `tasty`,
* `test-framework-hunit` -> `tasty-hunit`,
* `test-framework-quickcheck2` -> `tasty-quickcheck`.
* Replace module imports:
* `Test.Framework` -> `Test.Tasty`,
* `Test.Framework.Providers.HUnit` -> `Test.Tasty.HUnit`,
* `Test.Framework.Providers.QuickCheck2` -> `Test.Tasty.QuickCheck`.
* Replace in type signatures:
* `Test` -> `TestTree`.
* Replace `defaultMain tests` with `defaultMain (testGroup "All" tests)`.
Member
There was a problem hiding this comment.
This section is for "new users" and kept brief on purpose.
- For existing users, there is no need to necessarily migrate to anything.
- If existing users choose to migrate to something else, I trust them to be able to figure out themselves how to do this.
- If you want to provide instructions on how to migrate from
test-frameworkto your project then I think this belongs into the documentation of your project.
Member
There was a problem hiding this comment.
Also, for what it's worth:
### Migration to `hspec`
The following steps are sufficient:
* Add to `build-depends`:
* `hspec-test-framework`
* Remove from`build-depends`:
* `test-framework`
* `test-framework-hunit`
* `test-framework-quickcheck2`
* Replace `test-framework-th` with `hspec-test-framework-th`But really, I don't think any of this belongs here.
Co-authored-by: Simon Hengel <sol@typeful.net> Co-authored-by: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>
Member
Author
|
I merged your suggestions. |
sol
reviewed
Feb 26, 2025
Spare users of this library the compilation warnings.
acb7d59 to
39a5f41
Compare
Member
Author
|
Published! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sol I am accepting reformulations of the READMEs if you want to suggest some, see
Closes #71, closes #72.