-
Notifications
You must be signed in to change notification settings - Fork 70
Add documentation for GHC-21926 #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c26d0f2
Document GHC-21926
FPtje cc1d70d
Apply suggested title change
FPtje d5901c6
Explain alphanumeric characters
FPtje 95967c6
Reword the explanation of GHC-21926
FPtje d406932
Add full stops and extension to GHC-21926
FPtje f1fde5c
Add suggested nuance
FPtje File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
title: Version number or non-alphanumeric character in package name | ||
summary: Package imports may only consist of alphanumeric characters, and must omit the version | ||
severity: error | ||
introduced: 9.6.1 | ||
--- | ||
|
||
Version number or non-alphanumeric character in package name. | ||
The package name in this case refers to the package specified with imports after enabling the `PackageImports` language extension. |
5 changes: 5 additions & 0 deletions
5
...index/messages/GHC-21926/non-alphanumeric-in-package/after/Non-alphanumeric-in-package.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{-# LANGUAGE PackageImports #-} | ||
|
||
module NonAlphanumericCharacterNameInPackage where | ||
|
||
import "some-existing-package" Package.With.Non.Alphanumeric.Characters |
5 changes: 5 additions & 0 deletions
5
...ndex/messages/GHC-21926/non-alphanumeric-in-package/before/Non-alphanumeric-in-package.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{-# LANGUAGE PackageImports #-} | ||
|
||
module NonAlphanumericCharacterNameInPackage where | ||
|
||
import "&*$^%!@()" Package.With.Non.Alphanumeric.Characters |
3 changes: 3 additions & 0 deletions
3
message-index/messages/GHC-21926/non-alphanumeric-in-package/index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
title: Non-alphanumeric characters in the package name | ||
--- |
5 changes: 5 additions & 0 deletions
5
message-index/messages/GHC-21926/version-number-in-package/after/Version-name-in-package.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{-# LANGUAGE PackageImports #-} | ||
|
||
module VersionNameInPackage where | ||
|
||
import "some-package" Package.With.Version |
5 changes: 5 additions & 0 deletions
5
message-index/messages/GHC-21926/version-number-in-package/before/Version-name-in-package.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{-# LANGUAGE PackageImports #-} | ||
|
||
module VersionNameInPackage where | ||
|
||
import "some-package-0.1.2.3" Package.With.Version |
3 changes: 3 additions & 0 deletions
3
message-index/messages/GHC-21926/version-number-in-package/index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
title: Version number in package | ||
FPtje marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
--- |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.