Add basic haskell-nix setup #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @MangoIV . Can you take a look at the nix flake? |
MangoIV
reviewed
Oct 13, 2024
flake.nix
Outdated
Comment on lines
47
to
57
| # packages = {}; | ||
| # settings = {}; | ||
| projectRoot = ./message-index; | ||
| # devShell.mkShellArgs = { | ||
| # packages = [ | ||
| # # pkgs.zlib.dev | ||
| # # pkgs.haskellPackages.zlib | ||
| # # pkgs.haskellPackages.zlib_0_7_1_0.dev | ||
| # ]; | ||
| # # shellHook = config.pre-commit.installationScript; | ||
| # }; |
There was a problem hiding this comment.
Suggested change
| # packages = {}; | |
| # settings = {}; | |
| projectRoot = ./message-index; | |
| # devShell.mkShellArgs = { | |
| # packages = [ | |
| # # pkgs.zlib.dev | |
| # # pkgs.haskellPackages.zlib | |
| # # pkgs.haskellPackages.zlib_0_7_1_0.dev | |
| # ]; | |
| # # shellHook = config.pre-commit.installationScript; | |
| # }; | |
| projectRoot = ./message-index; |
Comment on lines
41
to
43
| alejandra.enable = true; | ||
| statix.enable = true; | ||
| deadnix.enable = true; |
There was a problem hiding this comment.
i think it would be good to remove statix from here, it sucks.
Suggested change
| alejandra.enable = true; | |
| statix.enable = true; | |
| deadnix.enable = true; | |
| alejandra.enable = true; | |
| deadnix.enable = true; |
Comment on lines
+38
to
+39
| cabal-fmt.enable = true; | ||
| hlint.enable = true; |
There was a problem hiding this comment.
Suggested change
| cabal-fmt.enable = true; | |
| hlint.enable = true; | |
| cabal-fmt.enable = true; | |
| hlint.enable = true; | |
| ormolu.enable = true; |
flake.nix
Outdated
| }; | ||
| outputs = inputs: | ||
| inputs.parts.lib.mkFlake {inherit inputs;} { | ||
| systems = ["x86_64-linux"]; |
There was a problem hiding this comment.
Suggested change
| systems = ["x86_64-linux"]; | |
| systems = ["x86_64-linux" "x86_64-darwin" "aarch64-linux" "aarch64-darwin"]; |
| deadnix.enable = true; | ||
| }; | ||
| }; | ||
| haskellProjects.ghc96 = { |
There was a problem hiding this comment.
Suggested change
| haskellProjects.ghc96 = { | |
| haskellProjects.ghc96 = { | |
| basePackages = pkgs.haskell.packages.ghc96; |
alternatively you can also rename this to smth like default-haskell or you can search fo the option on flake.parts that switches off the automatic population of default.
flake.nix
Outdated
Comment on lines
22
to
23
| # pkgs, | ||
| # lib, |
There was a problem hiding this comment.
Suggested change
| # pkgs, | |
| # lib, | |
| pkgs, |
This will be needed if you fix the basePackages, otherwise it can also be removed.
BinderDavid
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.