new landing — footer #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hasparus
commented
Jul 27, 2025
Comment on lines
+93
to
+96
| // { | ||
| // title: "Swag Shop", | ||
| // route: "https://store.graphql.org/", | ||
| // }, |
There was a problem hiding this comment.
@saihaj the footer in the design has links for the future state, with some pages that we don't have up yet, right?
So we probably wanna be somewhere in between current and designed.
The current footer includes a swag shop link. Should we get rid of the /spec link in favor of this one?
There was a problem hiding this comment.
keep the shop link. it's a store that still runs I believe. Honestly would keep all the links we have today in prod for footer.
There was a problem hiding this comment.
todo for me then, gonna keep all the old links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the Footer and Join the Community card.