Skip to content

chore: upgrade go v1.26 and dependencies#85

Merged
hgiasac merged 3 commits intomainfrom
chore/upgrade-ndc-go-230
Mar 10, 2026
Merged

chore: upgrade go v1.26 and dependencies#85
hgiasac merged 3 commits intomainfrom
chore/upgrade-ndc-go-230

Conversation

@hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Mar 10, 2026

This pull request introduces several important updates to the project, focusing on upgrading dependencies, enhancing observability and documentation, and improving code quality and maintainability. The most significant changes are the upgrade to Go 1.26.1, migration to the new gotel tracing library, improved documentation on features and CI/CD, and various dependency and code quality updates.

Dependency and Tooling Upgrades:

  • Upgraded the project to require Go 1.26.1 (was 1.24.x) in both go.mod, go.work, and Dockerfile. This includes updating the build image and documentation prerequisites. [1] [2] [3] [4]
  • Updated dependencies: switched to gotel for tracing, upgraded ndc-sdk-go, goenvconf, theory/jsonpath, and several OpenTelemetry and other libraries for improved performance and compatibility. [1] [2]

Tracing and Telemetry Improvements:

  • Migrated from the old connector.NewTracer to the new gotel.NewTracer in both connector/internal/client.go and connector/types.go for improved tracing consistency and future-proofing. [1] [2] [3]
  • Updated OpenTelemetry header handling to use otelutils.NewTelemetryHeaders for better integration. [1] [2]

Documentation Enhancements:

  • Expanded the CLAUDE.md documentation:
    • Added detailed descriptions of test fixtures, new features (compression, JSON Patch, distributed execution), and usage of the patch system. [1] [2] [3]
    • Documented new Makefile targets and described the CI/CD workflows and supported platforms. [1] [2]
    • Included linter configuration and complexity thresholds for code quality.

Code Quality and Minor Fixes:

  • Improved array index safety in connector/internal/contenttype/parameter.go and fixed string formatting for key indices. [1] [2]
  • In exhttp/retry.go, replaced the deprecated utils.ToPtr with a direct new call for schema descriptions. [1] [2]

Dependency and Tooling Upgrades

  • Upgraded project to Go 1.26.1 and updated Docker build image, go.mod, and go.work prerequisites. [1] [2] [3] [4]
  • Updated multiple dependencies: adopted gotel for tracing, upgraded ndc-sdk-go, goenvconf, theory/jsonpath, OpenTelemetry, and other libraries. [1] [2]

Tracing and Telemetry

  • Migrated all tracing from connector.NewTracer to gotel.NewTracer for improved observability. [1] [2] [3]
  • Updated OpenTelemetry header utilities to use otelutils.NewTelemetryHeaders. [1] [2]

Documentation and Developer Experience

  • Expanded and clarified documentation in CLAUDE.md:
    • Detailed test fixture structure and CI test script behavior.
    • Documented new features: compression, JSON Patch, distributed execution, and patch system usage. [1] [2]
    • Added Makefile targets and described CI/CD workflows and linter configuration. [1] [2] [3]

Code Quality and Safety

  • Improved array index safety and string formatting in parameter handling code. [1] [2]
  • Replaced deprecated pointer utility in schema descriptions with direct pointer creation. [1] [2]

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 62%
github.com/hasura/ndc-http/connector/internal/argument 59%
github.com/hasura/ndc-http/connector/internal 56%
github.com/hasura/ndc-http/connector/internal/contenttype 59%
github.com/hasura/ndc-http/connector/internal/security 68%
github.com/hasura/ndc-http/exhttp 63%
github.com/hasura/ndc-http/ndc-http-schema/command 60%
github.com/hasura/ndc-http/ndc-http-schema/configuration 63%
github.com/hasura/ndc-http/ndc-http-schema/ndc/internal 57%
github.com/hasura/ndc-http/ndc-http-schema/ndc 72%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 74%
github.com/hasura/ndc-http/ndc-http-schema/openapi 56%
github.com/hasura/ndc-http/ndc-http-schema/schema 64%
github.com/hasura/ndc-http/ndc-http-schema/utils 77%
Summary 64% (7864 / 12229)

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit 68f9c30 into main Mar 10, 2026
8 checks passed
@hgiasac hgiasac deleted the chore/upgrade-ndc-go-230 branch March 10, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant